Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Remove check not allowing translations to run on net9.0 #24724

Closed
wants to merge 1 commit into from

Conversation

tj-devel709
Copy link
Member

Description of Change

In the net9.0 branch, the translations section is not being applied. - ${{ if eq(variables['System.TeamProject'], 'devdiv') }}: being false caused the localization templates not to be run. I'm not sure if we need to replace this with something else but I think it should work as this PR has it since that templates all have their own checks on whether to run.

Issues Fixed

Fixes #

@tj-devel709 tj-devel709 added the area-localization Localization and globalization issues label Sep 11, 2024
@tj-devel709 tj-devel709 requested a review from a team as a code owner September 11, 2024 21:38
@rmarinho
Copy link
Member

rmarinho commented Sep 11, 2024

Did we got anything for main? translations only happen on devdiv, having that code shouldn't t be the issue

@tj-devel709
Copy link
Member Author

Did we got anything for main? translations only happen on devdiv, having that code shouldn't t be the issue

Yeah it is being run in main right now: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10209378&view=logs&s=266d6c29-b55e-56e1-41c4-d0d9dc0f16a7

@tj-devel709
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s).

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to look at variables that start the process on common/variables.yaml

@tj-devel709
Copy link
Member Author

you need to look at variables that start the process on common/variables.yaml

The variable of System.TeamProject that was being used before does not appear to be in common/variables.yaml if that is what you mean? It seems to be an environment var that contains devdiv in the main branch but not in the net9.0 branch. Maybe it should be set in the net9.0 branch?

@tj-devel709
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s).

@tj-devel709
Copy link
Member Author

This is incorrect and not needed!

@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-localization Localization and globalization issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants