-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Localization] Remove check not allowing translations to run on net9.0 #24724
Conversation
Did we got anything for main? translations only happen on devdiv, having that code shouldn't t be the issue |
Yeah it is being run in main right now: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10209378&view=logs&s=266d6c29-b55e-56e1-41c4-d0d9dc0f16a7 |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to look at variables that start the process on common/variables.yaml
The variable of |
a4c4c74
to
c555c0c
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s). |
This is incorrect and not needed! |
Description of Change
In the net9.0 branch, the translations section is not being applied.
- ${{ if eq(variables['System.TeamProject'], 'devdiv') }}:
being false caused the localization templates not to be run. I'm not sure if we need to replace this with something else but I think it should work as this PR has it since that templates all have their own checks on whether to run.Issues Fixed
Fixes #